Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventEmitter: add EventEmitter#once(event[], ...) #779

Merged
merged 1 commit into from
Jul 29, 2021
Merged

EventEmitter: add EventEmitter#once(event[], ...) #779

merged 1 commit into from
Jul 29, 2021

Conversation

SimonWoolf
Copy link
Member

Had occasion to use once(['enter', 'update']) in a realtime test, discovered I'd never gotten around to implementing it in ably-js

@SimonWoolf SimonWoolf requested review from owenpearson and removed request for owenpearson July 27, 2021 16:39
owenpearson
owenpearson approved these changes Jul 29, 2021
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@SimonWoolf SimonWoolf merged commit 48d6644 into main Jul 29, 2021
@SimonWoolf SimonWoolf deleted the once-array branch July 29, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonWoolf @owenpearson